linux-kernel - Re: [PATCH] pci: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 11:02:59 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     trix@...hat.com
Cc:     linus.walleij@...aro.org, lorenzo.pieralisi@....com,
        robh@...nel.org, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: remove unneeded break

On Mon, Oct 19, 2020 at 12:02:49PM -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied with Linus' reviewed-by to pci/misc for v5.10, thanks!

> ---
>  drivers/pci/controller/pci-v3-semi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index 1f54334f09f7..154a5398633c 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
>  	default:
>  		dev_err(v3->dev, "illegal dma memory chunk size\n");
>  		return -EINVAL;
> -		break;
>  	}
>  	val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
>  	*pci_map = val;
> -- 
> 2.18.1
>