linux-kernel - Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fb3199f-f5a6-fa00-94df-9c5a40f394b6@baylibre.com>
Date:   Tue, 20 Oct 2020 18:11:12 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>
Cc:     Anand Moon <linux.amoon@...il.com>,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID

On 20/10/2020 16:49, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@...libre.com> writes:
> 
>> On 20/10/2020 14:01, Jerome Brunet wrote:
>>> From: Anand Moon <linux.amoon@...il.com>
>>>
>>> Add reset external reset of the ethernet mac controller
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@...il.com>
>>> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> 
> [...]
> 
>> Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
> 
> Neil, do we need this in u-boot also?  I seem to have network issues in
> u-boot on board with external PHY running mainline u-boot.

Yes, U-boot supports it, but simply does "reset_deassert", so I don't think
it would have any impact, the real issue is the PHY reset.

Without a proper reset line, no idea how to do that cleanly.

Neil

> 
> Kevin
>