linux-kernel - Re: [PATCH] net: dsa: bcm_sf2: make const array static, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 09:51:39 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2: make const array static, makes object
 smaller

On 10/20/20 9:50 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const array rate_table on the stack but instead it
> static. Makes the object code smaller by 46 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   29812	   3824	    192	  33828	   8424	drivers/net/dsa/bcm_sf2.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   29670	   3920	    192	  33782	   83f6	drivers/net/dsa/bcm_sf2.o
> 
> (gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian