linux-kernel - Re: [PATCH] cifs: make const array static, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5muM5K802hub3WYJYcC5Mqi8K2S2HJa1hgW_mo+oW0toMA@mail.gmail.com>
Date:   Tue, 20 Oct 2020 11:55:38 -0500
From:   Steve French <smfrench@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Aurélien Aptel <aaptel@...e.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: make const array static, makes object smaller

added Aurelien's Reviewed-by and merged into cifs-2.6.git for-next

On Tue, Oct 20, 2020 at 9:22 AM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> Don't populate const array smb3_create_tag_posix on the stack but
> instead make it static. Makes the object code smaller by 50 bytes.
>
> Before:
>    text    data     bss     dec     hex filename
>  150184   47167       0  197351   302e7 fs/cifs/smb2pdu.o
>
> After:
>     text           data     bss     dec     hex filename
>  150070   47231       0  197301   302b5 fs/cifs/smb2pdu.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/cifs/smb2pdu.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index d504bc296349..be8696abd871 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -1971,9 +1971,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,
>         unsigned int next;
>         unsigned int remaining;
>         char *name;
> -       const char smb3_create_tag_posix[] = {0x93, 0xAD, 0x25, 0x50, 0x9C,
> -                                       0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83,
> -                                       0xDE, 0x96, 0x8B, 0xCD, 0x7C};
> +       static const char smb3_create_tag_posix[] = {
> +               0x93, 0xAD, 0x25, 0x50, 0x9C,
> +               0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83,
> +               0xDE, 0x96, 0x8B, 0xCD, 0x7C
> +       };
>
>         *oplock = 0;
>         data_offset = (char *)rsp + le32_to_cpu(rsp->CreateContextsOffset);
> --
> 2.27.0
>


-- 
Thanks,

Steve