linux-kernel - Re: [PATCH 1/2] cifs: convert to add_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 12:08:36 -0500
From:   Steve French <smfrench@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>
Subject: Re: [PATCH 1/2] cifs: convert to add_to_page_cache()

Other than the unnecessary split line which Christoph pointed out, looks fine.

You can add my Reviewed--by: Steve French <stfrench@...rosoft.com>

On Tue, Oct 20, 2020 at 5:10 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> > +     rc = add_to_page_cache(page, mapping,
> > +                            page->index, gfp);
>
> This trivially fits onto a single line.



-- 
Thanks,

Steve