linux-kernel - Re: [PATCH v2] ASoC: amd: move the call to devm_kzalloc below platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201021094129.GA4497@sirena.org.uk>
Date:   Wed, 21 Oct 2020 10:41:29 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Defang Bo <bodefang@....com>
Cc:     perex@...ex.cz, tiwai@...e.com, lgirdwood@...il.com,
        Vishnuvardhanrao.Ravulapati@....com, akshu.agrawal@....com,
        weiyongjun1@...wei.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: amd: move the call to devm_kzalloc below
 platform_get_resource()

On Wed, Oct 21, 2020 at 03:04:27PM +0800, Defang Bo wrote:

> Just as the commit <4cb79ef9c6c4>("ASoC: amd: Fix potential NULL pointer dereference"),it makes no sense to allocate any resources if platform_get_resource fails,so move the call to devm_kzalloc() below the mentioned code.

As I said on my previous mail:

| Please keep your commit message wrapped at below 80 columns.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

>  	}
> +
>  	adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data), GFP_KERNEL);
>  	if (!adata)
>  		return -ENOMEM;
> +
>  	adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,

This appears to add new whitespace, it doesn't seem to do what the
commit log says?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)