linux-kernel - Re: [PATCH v2] power: suspend: Replace dpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hBkJ5VMQ1PYg7n=kdrwx1s3nMXN95coKfmMDsg4F=L2g@mail.gmail.com>
Date:   Wed, 21 Oct 2020 11:51:29 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Joseph Jang <josephjang@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>, jonglin@...gle.com,
        woodylin@...gle.com, Mark Cheng <markcheng@...gle.com>
Subject: Re: [PATCH v2] power: suspend: Replace dpm_watchdog by sleep timer

On Wed, Oct 21, 2020 at 4:09 AM Joseph Jang <josephjang@...gle.com> wrote:
>
> Since dpm_watchdog just cover device power management, we proposed sleep
> timer to cover not only device power management hang issues, but also
> core power management hand issue.
>
> Add sleep timer and timeout handler to prevent device stuck during suspend/
> resume process. The timeout handler will dump disk sleep task at first
> round timeout and trigger kernel panic at second round timeout.
> The default timer for each round is defined in
> CONFIG_PM_SLEEP_TIMER_TIMEOUT.

Let me repeat the point that Greg has made already: Please don't
replace the existing watchdog with something else, but try to extend
it to cover your use case.

As it stands, the patch is not applicable IMV.

Thanks!