lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Oct 2020 13:27:24 +0300 From: Sergei Shtepa <sergei.shtepa@...am.com> To: Damien Le Moal <Damien.LeMoal@....com> CC: "axboe@...nel.dk" <axboe@...nel.dk>, "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>, "hch@...radead.org" <hch@...radead.org>, "darrick.wong@...cle.com" <darrick.wong@...cle.com>, "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "rjw@...ysocki.net" <rjw@...ysocki.net>, "len.brown@...el.com" <len.brown@...el.com>, "pavel@....cz" <pavel@....cz>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, Johannes Thumshirn <Johannes.Thumshirn@....com>, "ming.lei@...hat.com" <ming.lei@...hat.com>, "jack@...e.cz" <jack@...e.cz>, "tj@...nel.org" <tj@...nel.org>, "gustavo@...eddedor.com" <gustavo@...eddedor.com>, "bvanassche@....org" <bvanassche@....org>, "osandov@...com" <osandov@...com>, "koct9i@...il.com" <koct9i@...il.com>, "steve@....org" <steve@....org>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org> Subject: Re: [PATCH 1/2] Block layer filter - second version EXPORT_SYMBOL_GPL - ok. #ifdef CONFIG_BLK_FILTER or IS_ENABLED() - It's a matter of habit. > double blank line Ok, I did. Looks like a candidate for ./scripts/checkpatch.pl. > Separate into multiple patches: one that introduces the filter > functions/ops code and another that changes the block layer where needed. I'll think about it. Personally, it seems to me that this separation does not make it easier to understand the code. It is important for me to know immediately where the function is called, and this determines its behavior. -- Sergei Shtepa Veeam Software developer.
Powered by blists - more mailing lists