linux-kernel - Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201021180114.4b478b06@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 21 Oct 2020 18:01:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xie He <xie.he.0141@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Neil Horman <nhorman@...driver.com>,
        Krzysztof Halasa <khc@...waw.pl>
Subject: Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING
 flag after calling ether_setup

On Mon, 19 Oct 2020 23:34:20 -0700 Xie He wrote:
> This driver calls ether_setup to set up the network device.
> The ether_setup function would add the IFF_TX_SKB_SHARING flag to the
> device. This flag indicates that it is safe to transmit shared skbs to
> the device.
> 
> However, this is not true. This driver may pad the frame (in eth_tx)
> before transmission, so the skb may be modified.
> 
> Cc: Neil Horman <nhorman@...driver.com>
> Cc: Krzysztof Halasa <khc@...waw.pl>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thank you. 

In the future please try to provide a Fixes: tag.