linux-kernel - Re: [PATCH] arm64: dts: imx8m: use generic name for tmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 11:06:46 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     peng.fan@....com
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com,
        robh+dt@...nel.org, kernel@...gutronix.de, linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, marex@...x.de
Subject: Re: [PATCH] arm64: dts: imx8m: use generic name for tmu

On Thu, Oct 22, 2020 at 03:21:18PM +0800, peng.fan@....com wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Per devicetree specification, generic names are recommended
> to be used, such as temperature-sensor.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index b83f400def8b..327f1d44ced9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -404,7 +404,7 @@ gpio5: gpio@...40000 {
>  				gpio-ranges = <&iomuxc 0 119 30>;
>  			};
>  
> -			tmu: tmu@...60000 {
> +			tmu: temperature-sensor@...60000 {

No, TMU is not a temperature-sensor. It does much more. TMU is quite
generic name for this class of device.

Best regards,
Krzysztof