linux-kernel - Re: [PATCH 1/2] perf jevents: Tidy error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <348855b5-d109-3e30-a669-d4e2c766ad30@huawei.com>
Date:   Thu, 22 Oct 2020 10:43:48 +0100
From:   John Garry <john.garry@...wei.com>
To:     kajoljain <kjain@...ux.ibm.com>, Namhyung Kim <namhyung@...nel.org>
CC:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, Ian Rogers <irogers@...gle.com>,
        Yao Jin <yao.jin@...ux.intel.com>, <yeyunfeng@...wei.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH 1/2] perf jevents: Tidy error handling

On 21/10/2020 14:37, kajoljain wrote:
>>> May be we can use similar checks:
>>>
>>> if( verbose)
>>>     pr_info("%s: Error walking file tree %s%s\n", prog, ldirname,err_string_ext);
>>> if(rc > 0)
>>>      empty_map = 1;
>>> else
>>>     ret = 1;
>>>
>> Not that it matters much, this logic is slightly different for verbose set and rc < 0. I don't mind going with that, so let me know.
> Yes right. Sure if required we can made changes on these checks and include appropriate condition for verbose set and rc < 0. Seems fine to me.

I will just revert to the original logic for now. Someone can try to 
change later if they want.

Thanks