linux-kernel - Re: [GIT PULL] prandom32 changes for v5.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201022021225.GA911@1wt.eu>
Date:   Thu, 22 Oct 2020 04:12:25 +0200
From:   Willy Tarreau <w@....eu>
To:     Joe Perches <joe@...ches.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Marc Plumb <lkml.mplumb@...il.com>,
        Amit Klein <aksecurity@...il.com>,
        George Spelvin <lkml@....org>,
        Eric Dumazet <edumazet@...gle.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Andy Lutomirski <luto@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        "Theodore Ts'o" <tytso@....edu>, Florian Westphal <fw@...len.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] prandom32 changes for v5.10

On Wed, Oct 21, 2020 at 02:41:06PM -0700, Joe Perches wrote:
> On Wed, 2020-10-21 at 14:35 -0700, Linus Torvalds wrote:
> > On Wed, Oct 21, 2020 at 2:20 PM Joe Perches <joe@...ches.com> wrote:
> > > While secure solutions are useful, I really wonder if
> > > "George Spelvin" is a real person.
> > 
> > It's not his real name, no, but he's a real person.
> > 
> > I do have his real name from years ago when I needed to confirm his
> > identity for sign-offs (I forget what for, I think it was some dcache
> > name hashing thing).
> > 
> > So I can confirm he's a real person who just wants to keep private,
> > and is competent when it comes to hashing and security.
> 
> I hope that real name is in some escrow somewhere and
> not just in some long thrown away spinning rust disk.
> 
> And because George isn't a real name and contributions
> by him have been accepted, the DCO should be updated
> to show how pseudonymous contributions can be made.

Well, if that helps, given that I already needed to modify his code
and that his proposal totally makes sense, I can also replace his
signed-off-by with a suggested-by in the patch and put a link to the
original thread.

I'll do my best to propose an update before -rc1 if that's still
acceptable. Amit found that the code doesn't build when tests are
enabled, visibly they were not on my side and likely explain why
that failed for Linus.

Willy