linux-kernel - Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 15:50:08 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Izabela Bakollari <izabela.bakollari@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line alignment



On Thu, 22 Oct 2020, izabela.bakollari@...il.com wrote:

> From: Izabela Bakollari <izabela.bakollari@...il.com>
>
> Fix code alignment. Issue reported by checkpatch.pl

Try to find something other than "Fix" to describe what you have done.
What kind of change have you made and why is it a good idea?
>
> Signed-off-by: Izabela Bakollari <izabela.bakollari@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index a908ff301707..1bd36dc2b7ff 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1198,8 +1198,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  			if (wlandev->netdev->type == ARPHRD_ETHER) {
>  				/* Save macport 0 state */
>  				result = hfa384x_drvr_getconfig16(hw,
> -						  HFA384x_RID_CNFPORTTYPE,
> -						  &hw->presniff_port_type);
> +								  HFA384x_RID_CNFPORTTYPE,
> +								  &hw->presniff_port_type);

I think that the code was nicer before.  Staying inside 80 characters is
worth something, and having the arguments lined up with the ( seems lees
important in this case.  It could be a concern if the arguments eg ended
up right under the function name, because that would be easy to misread,
but that is not the case here.

julia

>  				if (result) {
>  					netdev_dbg
>  					(wlandev->netdev,
> --
> 2.18.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201022132218.235744-1-izabela.bakollari%40gmail.com.
>