linux-kernel - Reducing number of Espressobin DTS files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201022140007.hppmeyt34lubotbc@pali>
Date:   Thu, 22 Oct 2020 16:00:07 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Gregory CLEMENT <gregory.clement@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        Andre Heider <a.heider@...il.com>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Reducing number of Espressobin DTS files

Hello!

For Espressobin A3720 board there are currently 4 DTS files:

https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts?h=for-next

There are two board revisions (V5 and V7) and each has variant with and
without eMMC.

V5 and V7 DTS files differs order of ethernet switch ports and presence
of led2 (not in next branch yet).

I would like to ask, do we need two DTS files for eMMC and non-eMMC
variants? Is there any issue if we enable sdhci0 globally for all
Espressobin board and therefore reduce number of DTS variants?

For example, Turris MOX board which is also A3720 based has optional
SDIO module which can be plugged / unplugged, standard variant is sold
without it and in DTS file is this node always enabled:

https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts?h=for-next#n178

Could not we enable by default this node also on Espressobin? It is a
problem if node for eMMC is enabled also on board without eMMC? As it
would simplify configuration, compilation and setup of system for
Espressobin boards.