linux-kernel - Re: [PATCH] PM: sleep: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ifnZb4p+EBeYdggVm_VB54fX-HaMJX7vgkY0UnHJOEYg@mail.gmail.com>
Date:   Thu, 22 Oct 2020 18:48:26 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     trix@...hat.com
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM: sleep: remove unneeded break

On Mon, Oct 19, 2020 at 10:03 PM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/base/power/main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 205a06752ca9..c7ac49042cee 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -363,7 +363,6 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state)
>         case PM_EVENT_THAW:
>         case PM_EVENT_RECOVER:
>                 return ops->thaw;
> -               break;
>         case PM_EVENT_RESTORE:
>                 return ops->restore;
>  #endif /* CONFIG_HIBERNATE_CALLBACKS */
> --

Applied as 5.10-rc material with edits in the subject and changelog, thanks!