linux-kernel - Re: [PATCH] acpi: utils: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 18:59:58 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     trix@...hat.com
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: utils: remove unneeded break

On Mon, Oct 19, 2020 at 10:05 PM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/acpi/utils.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 838b719ec7ce..d5411a166685 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -104,7 +104,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>
> @@ -129,7 +128,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " expecting [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>                 case ACPI_TYPE_LOCAL_REFERENCE:
> @@ -144,7 +142,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " expecting [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>
> @@ -155,7 +152,6 @@ acpi_extract_package(union acpi_object *package,
>                                           i));
>                         /* TBD: handle nested packages... */
>                         return AE_SUPPORT;
> -                       break;
>                 }
>         }
>
> --

Applied as 5.10-rc material with subject and changelog edits, thanks!