linux-kernel - Re: [PATCH v2 01/15] perf session: introduce trace file path to be shown in raw trace dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 13:28:54 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Alexey Budankov <alexey.budankov@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/15] perf session: introduce trace file path to be
 shown in raw trace dump

Hi,

On Thu, Oct 22, 2020 at 12:56 AM Alexey Budankov
<alexey.budankov@...ux.intel.com> wrote:
>
>
> Extend reader, ordered_event and decomp objects to contain path
> of a trace file being displayed.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@...ux.intel.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks
Namhyung

> ---
>  tools/perf/util/ordered-events.h | 1 +
>  tools/perf/util/session.c        | 2 ++
>  tools/perf/util/session.h        | 1 +
>  3 files changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/ordered-events.h b/tools/perf/util/ordered-events.h
> index 75345946c4b9..42c9764c6b5b 100644
> --- a/tools/perf/util/ordered-events.h
> +++ b/tools/perf/util/ordered-events.h
> @@ -9,6 +9,7 @@ struct perf_sample;
>  struct ordered_event {
>         u64                     timestamp;
>         u64                     file_offset;
> +       const char              *file_path;
>         union perf_event        *event;
>         struct list_head        list;
>  };
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 7a5f03764702..4478ddae485b 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -2119,6 +2119,7 @@ typedef s64 (*reader_cb_t)(struct perf_session *session,
>
>  struct reader {
>         int              fd;
> +       const char       *path;
>         u64              data_size;
>         u64              data_offset;
>         reader_cb_t      process;
> @@ -2241,6 +2242,7 @@ static int __perf_session__process_events(struct perf_session *session)
>                 .data_size      = session->header.data_size,
>                 .data_offset    = session->header.data_offset,
>                 .process        = process_simple,
> +               .path           = session->data->file.path,
>         };
>         struct ordered_events *oe = &session->ordered_events;
>         struct perf_tool *tool = session->tool;
> diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
> index f76480166d38..378ffc3e2809 100644
> --- a/tools/perf/util/session.h
> +++ b/tools/perf/util/session.h
> @@ -46,6 +46,7 @@ struct perf_session {
>  struct decomp {
>         struct decomp *next;
>         u64 file_pos;
> +       const char *file_path;
>         size_t mmap_len;
>         u64 head;
>         size_t size;
> --
> 2.24.1
>
>