linux-kernel - Re: [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201023210935.GG20115@casper.infradead.org>
Date:   Fri, 23 Oct 2020 22:09:35 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Rik van Riel <riel@...riel.com>
Cc:     Hugh Dickins <hughd@...gle.com>, Yu Xu <xuyu@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...e.de>,
        Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
        kernel-team@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp_mask

On Fri, Oct 23, 2020 at 04:47:08PM -0400, Rik van Riel wrote:
> +++ b/include/linux/gfp.h
> @@ -614,6 +614,8 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask);
>  extern void pm_restrict_gfp_mask(void);
>  extern void pm_restore_gfp_mask(void);
>  
> +extern gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma);

Without the types, the name of this function makes me think it allocates
something.  Like alloc_hugepage_vma() does.  With the types, it's obvious
that it gets the gfpmask.  Can this patch rename it, perhaps to

gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma);

(hugepage is also ambiguous because it might be for hugetlbfs and we use,
eg, mapping_gfp_mask, not mapping_gfpmask).