linux-kernel - Re: [PATCH] PCI: export pci_find_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201023064740.GB22405@infradead.org>
Date:   Fri, 23 Oct 2020 07:47:40 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Paul Burton <paulburton@...nel.org>,
        linux-mips@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: export pci_find_host_bridge() to fix MFD build error

On Wed, Oct 21, 2020 at 12:08:45PM +0200, Thomas Bogendoerfer wrote:
> On Tue, Oct 20, 2020 at 09:02:19AM +0100, Christoph Hellwig wrote:
> > On Sun, Oct 18, 2020 at 11:14:53PM -0700, Randy Dunlap wrote:
> > > Fix a build error in drivers/mfd/ioc.o by exporting
> > > pci_find_host_bridge().
> > > 
> > > ERROR: modpost: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined!
> > 
> > I think the mfd code should be fixed to not depend on such an internal
> > symbol instead.
> 
> are you talking about the EXPORT_SYMBOL or the usage of
> pci_find_host_bridge() outside of drivers/pci ? If the latter the
> function is used in arm/arm64 code and pci controller code... so
> I doesn't look like a pure internal symbol to me.

All of those are built-in and related bits aren't exported at all, or
at best EXPORT_SYMBOL_GPL.  I think just not allowing the ioc3 mfd to
be built modular might be the easiest fix here.  Especially as for IP27
and co kernel it is everything but optional anyway.