| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2c52262f-c54e-dbb0-c906-e4339595e53b@redhat.com>
Date: Fri, 23 Oct 2020 16:46:27 +0800
From: Jason Wang <jasowang@...hat.com>
To: kernel test robot <lkp@...el.com>, mst@...hat.com,
virtualization@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, rob.miller@...adcom.com,
lingshan.zhu@...el.com, eperezma@...hat.com, lulu@...hat.com,
shahafs@...lanox.com, hanand@...inx.com, mhabets@...arflare.com
Subject: Re: [PATCH V3 2/3] vhost: vdpa: report iova range
On 2020/10/23 下午1:28, kernel test robot wrote:
> Hi Jason,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on vhost/linux-next]
> [also build test WARNING on linus/master v5.9 next-20201023]
> [cannot apply to linux/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-API-for-reporting-IOVA-range/20201023-102708
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
> config: m68k-randconfig-r034-20201022 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/446e7b97838ebf87f1acd61580137716fdad104a
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Jason-Wang/vDPA-API-for-reporting-IOVA-range/20201023-102708
> git checkout 446e7b97838ebf87f1acd61580137716fdad104a
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> drivers/vhost/vdpa.c: In function 'vhost_vdpa_setup_vq_irq':
> drivers/vhost/vdpa.c:94:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> 94 | int ret, irq;
> | ^~~
> drivers/vhost/vdpa.c: In function 'vhost_vdpa_unlocked_ioctl':
This looks like another issue that needs to be fixed.
>>> drivers/vhost/vdpa.c:483:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 483 | r = copy_to_user(featurep, &features, sizeof(features));
> | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/vhost/vdpa.c:484:2: note: here
> 484 | case VHOST_VDPA_GET_IOVA_RANGE:
> | ^~~~
>
> vim +483 drivers/vhost/vdpa.c
My bad. V4 is on the road.
Thanks
>
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 426
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 427 static long vhost_vdpa_unlocked_ioctl(struct file *filep,
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 428 unsigned int cmd, unsigned long arg)
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 429 {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 430 struct vhost_vdpa *v = filep->private_data;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 431 struct vhost_dev *d = &v->vdev;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 432 void __user *argp = (void __user *)arg;
> a127c5bbb6a8eee Jason Wang 2020-09-07 433 u64 __user *featurep = argp;
> a127c5bbb6a8eee Jason Wang 2020-09-07 434 u64 features;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 435 long r;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 436
> a127c5bbb6a8eee Jason Wang 2020-09-07 437 if (cmd == VHOST_SET_BACKEND_FEATURES) {
> a127c5bbb6a8eee Jason Wang 2020-09-07 438 r = copy_from_user(&features, featurep, sizeof(features));
> a127c5bbb6a8eee Jason Wang 2020-09-07 439 if (r)
> a127c5bbb6a8eee Jason Wang 2020-09-07 440 return r;
> a127c5bbb6a8eee Jason Wang 2020-09-07 441 if (features & ~VHOST_VDPA_BACKEND_FEATURES)
> a127c5bbb6a8eee Jason Wang 2020-09-07 442 return -EOPNOTSUPP;
> a127c5bbb6a8eee Jason Wang 2020-09-07 443 vhost_set_backend_features(&v->vdev, features);
> a127c5bbb6a8eee Jason Wang 2020-09-07 444 return 0;
> a127c5bbb6a8eee Jason Wang 2020-09-07 445 }
> a127c5bbb6a8eee Jason Wang 2020-09-07 446
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 447 mutex_lock(&d->mutex);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 448
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 449 switch (cmd) {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 450 case VHOST_VDPA_GET_DEVICE_ID:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 451 r = vhost_vdpa_get_device_id(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 452 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 453 case VHOST_VDPA_GET_STATUS:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 454 r = vhost_vdpa_get_status(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 455 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 456 case VHOST_VDPA_SET_STATUS:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 457 r = vhost_vdpa_set_status(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 458 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 459 case VHOST_VDPA_GET_CONFIG:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 460 r = vhost_vdpa_get_config(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 461 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 462 case VHOST_VDPA_SET_CONFIG:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 463 r = vhost_vdpa_set_config(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 464 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 465 case VHOST_GET_FEATURES:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 466 r = vhost_vdpa_get_features(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 467 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 468 case VHOST_SET_FEATURES:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 469 r = vhost_vdpa_set_features(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 470 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 471 case VHOST_VDPA_GET_VRING_NUM:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 472 r = vhost_vdpa_get_vring_num(v, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 473 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 474 case VHOST_SET_LOG_BASE:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 475 case VHOST_SET_LOG_FD:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 476 r = -ENOIOCTLCMD;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 477 break;
> 776f395004d829b Zhu Lingshan 2020-06-05 478 case VHOST_VDPA_SET_CONFIG_CALL:
> 776f395004d829b Zhu Lingshan 2020-06-05 479 r = vhost_vdpa_set_config_call(v, argp);
> 776f395004d829b Zhu Lingshan 2020-06-05 480 break;
> a127c5bbb6a8eee Jason Wang 2020-09-07 481 case VHOST_GET_BACKEND_FEATURES:
> a127c5bbb6a8eee Jason Wang 2020-09-07 482 features = VHOST_VDPA_BACKEND_FEATURES;
> a127c5bbb6a8eee Jason Wang 2020-09-07 @483 r = copy_to_user(featurep, &features, sizeof(features));
> 446e7b97838ebf8 Jason Wang 2020-10-23 484 case VHOST_VDPA_GET_IOVA_RANGE:
> 446e7b97838ebf8 Jason Wang 2020-10-23 485 r = vhost_vdpa_get_iova_range(v, argp);
> a127c5bbb6a8eee Jason Wang 2020-09-07 486 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 487 default:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 488 r = vhost_dev_ioctl(&v->vdev, cmd, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 489 if (r == -ENOIOCTLCMD)
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 490 r = vhost_vdpa_vring_ioctl(v, cmd, argp);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 491 break;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 492 }
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 493
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 494 mutex_unlock(&d->mutex);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 495 return r;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 496 }
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 497
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists