linux-kernel - Re: [PATCH] kernel-doc: validate function prototype names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 18:18:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Cc:     kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
        linuxarm@...wei.com, mauro.chehab@...wei.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel-doc: validate function prototype names

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/kernel-doc-validate-function-prototype-names/20201023-153539
base:   git://git.lwn.net/linux-2.6 docs-next
config: microblaze-randconfig-r004-20201023 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5193d879fdb280898c28b196d3177b61d48fd2db
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/kernel-doc-validate-function-prototype-names/20201023-153539
        git checkout 5193d879fdb280898c28b196d3177b61d48fd2db
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/dma/xilinx/xilinx_dma.c:800: warning: expecting prototype for function xilinx_dma_tx_descriptor. Prototype was for function xilinx_dma_alloc_tx_descriptor instead
>> drivers/dma/xilinx/xilinx_dma.c:2452: warning: expecting prototype for function xilinx_dma_channel_set_config. Prototype was for function xilinx_vdma_channel_set_config instead

vim +800 drivers/dma/xilinx/xilinx_dma.c

9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  791  
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  792  /**
42c1a2ede4f6a32 drivers/dma/xilinx/xilinx_vdma.c Kedareswara rao Appana 2016-04-07  793   * xilinx_dma_tx_descriptor - Allocate transaction descriptor
42c1a2ede4f6a32 drivers/dma/xilinx/xilinx_vdma.c Kedareswara rao Appana 2016-04-07  794   * @chan: Driver specific DMA channel
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  795   *
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  796   * Return: The allocated descriptor on success and NULL on failure.
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  797   */
42c1a2ede4f6a32 drivers/dma/xilinx/xilinx_vdma.c Kedareswara rao Appana 2016-04-07  798  static struct xilinx_dma_tx_descriptor *
42c1a2ede4f6a32 drivers/dma/xilinx/xilinx_vdma.c Kedareswara rao Appana 2016-04-07  799  xilinx_dma_alloc_tx_descriptor(struct xilinx_dma_chan *chan)
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23 @800  {
42c1a2ede4f6a32 drivers/dma/xilinx/xilinx_vdma.c Kedareswara rao Appana 2016-04-07  801  	struct xilinx_dma_tx_descriptor *desc;
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  802  
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  803  	desc = kzalloc(sizeof(*desc), GFP_KERNEL);
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  804  	if (!desc)
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  805  		return NULL;
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  806  
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  807  	INIT_LIST_HEAD(&desc->segments);
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  808  
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  809  	return desc;
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  810  }
9cd4360de6090a6 drivers/dma/xilinx/xilinx_vdma.c Srikanth Thokala       2014-04-23  811  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31740 bytes)