| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <11e7c7dcb07ae258fa02e187c9697252f3835466.1603448113.git.viresh.kumar@linaro.org>
Date: Fri, 23 Oct 2020 15:50:21 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Amit Daniel Kachhap <amit.kachhap@...il.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Javi Merino <javi.merino@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Amit Kucheria <amitk@...nel.org>
Cc: linux-kernel@...r.kernel.org, Quentin Perret <qperret@...gle.com>,
Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org
Subject: [PATCH V2 2/2] thermal: cpufreq_cooling: Reuse sched_cpu_util()
Several parts of the kernel are already using the effective CPU
utilization (as seen by the scheduler) to get the current load on the
CPU, do the same here instead of depending on the idle time of the CPU,
which isn't that accurate comparatively.
Note that, this (and CPU frequency scaling in general) doesn't work that
well with idle injection as that is done from rt threads and is counted
as load while it tries to do quite the opposite. That should be solved
separately though.
Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
---
drivers/thermal/cpufreq_cooling.c | 70 +++++++------------------------
1 file changed, 16 insertions(+), 54 deletions(-)
diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index cc2959f22f01..1315e4d4758b 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -19,6 +19,7 @@
#include <linux/idr.h>
#include <linux/pm_opp.h>
#include <linux/pm_qos.h>
+#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/thermal.h>
@@ -38,16 +39,6 @@
* ...
*/
-/**
- * struct time_in_idle - Idle time stats
- * @time: previous reading of the absolute time that this cpu was idle
- * @timestamp: wall time of the last invocation of get_cpu_idle_time_us()
- */
-struct time_in_idle {
- u64 time;
- u64 timestamp;
-};
-
/**
* struct cpufreq_cooling_device - data for cooling device with cpufreq
* @id: unique integer value corresponding to each cpufreq_cooling_device
@@ -62,7 +53,6 @@ struct time_in_idle {
* registered cooling device.
* @policy: cpufreq policy.
* @node: list_head to link all cpufreq_cooling_device together.
- * @idle_time: idle time stats
* @qos_req: PM QoS contraint to apply
*
* This structure is required for keeping information of each registered
@@ -76,7 +66,6 @@ struct cpufreq_cooling_device {
struct em_perf_domain *em;
struct cpufreq_policy *policy;
struct list_head node;
- struct time_in_idle *idle_time;
struct freq_qos_request qos_req;
};
@@ -132,34 +121,18 @@ static u32 cpu_power_to_freq(struct cpufreq_cooling_device *cpufreq_cdev,
}
/**
- * get_load() - get load for a cpu since last updated
- * @cpufreq_cdev: &struct cpufreq_cooling_device for this cpu
+ * get_load() - get current load for a cpu
* @cpu: cpu number
- * @cpu_idx: index of the cpu in time_in_idle*
*
- * Return: The average load of cpu @cpu in percentage since this
- * function was last called.
+ * Return: The current load of cpu @cpu in percentage.
*/
-static u32 get_load(struct cpufreq_cooling_device *cpufreq_cdev, int cpu,
- int cpu_idx)
+static u32 get_load(int cpu)
{
- u32 load;
- u64 now, now_idle, delta_time, delta_idle;
- struct time_in_idle *idle_time = &cpufreq_cdev->idle_time[cpu_idx];
-
- now_idle = get_cpu_idle_time(cpu, &now, 0);
- delta_idle = now_idle - idle_time->time;
- delta_time = now - idle_time->timestamp;
+ unsigned long max = arch_scale_cpu_capacity(cpu);
+ unsigned long util;
- if (delta_time <= delta_idle)
- load = 0;
- else
- load = div64_u64(100 * (delta_time - delta_idle), delta_time);
-
- idle_time->time = now_idle;
- idle_time->timestamp = now;
-
- return load;
+ util = sched_cpu_util(cpu, ENERGY_UTIL, max);
+ return (util * 100) / max;
}
/**
@@ -191,13 +164,12 @@ static u32 get_dynamic_power(struct cpufreq_cooling_device *cpufreq_cdev,
* Instead, we calculate the current power on the assumption that the
* immediate future will look like the immediate past.
*
- * We use the current frequency and the average load since this
- * function was last called. In reality, there could have been
- * multiple opps since this function was last called and that affects
- * the load calculation. While it's not perfectly accurate, this
- * simplification is good enough and works. REVISIT this, as more
- * complex code may be needed if experiments show that it's not
- * accurate enough.
+ * We use the current frequency and the current load. In reality,
+ * there could have been multiple opps since this function was last
+ * called and that affects the load calculation. While it's not
+ * perfectly accurate, this simplification is good enough and works.
+ * REVISIT this, as more complex code may be needed if experiments show
+ * that it's not accurate enough.
*
* Return: 0 on success, -E* if getting the static power failed.
*/
@@ -223,7 +195,7 @@ static int cpufreq_get_requested_power(struct thermal_cooling_device *cdev,
u32 load;
if (cpu_online(cpu))
- load = get_load(cpufreq_cdev, cpu, i);
+ load = get_load(cpu);
else
load = 0;
@@ -517,13 +489,6 @@ __cpufreq_cooling_register(struct device_node *np,
cpufreq_cdev->policy = policy;
num_cpus = cpumask_weight(policy->related_cpus);
- cpufreq_cdev->idle_time = kcalloc(num_cpus,
- sizeof(*cpufreq_cdev->idle_time),
- GFP_KERNEL);
- if (!cpufreq_cdev->idle_time) {
- cdev = ERR_PTR(-ENOMEM);
- goto free_cdev;
- }
/* max_level is an index, not a counter */
cpufreq_cdev->max_level = i - 1;
@@ -531,7 +496,7 @@ __cpufreq_cooling_register(struct device_node *np,
ret = ida_simple_get(&cpufreq_ida, 0, 0, GFP_KERNEL);
if (ret < 0) {
cdev = ERR_PTR(ret);
- goto free_idle_time;
+ goto free_cdev;
}
cpufreq_cdev->id = ret;
@@ -580,8 +545,6 @@ __cpufreq_cooling_register(struct device_node *np,
freq_qos_remove_request(&cpufreq_cdev->qos_req);
remove_ida:
ida_simple_remove(&cpufreq_ida, cpufreq_cdev->id);
-free_idle_time:
- kfree(cpufreq_cdev->idle_time);
free_cdev:
kfree(cpufreq_cdev);
return cdev;
@@ -674,7 +637,6 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)
thermal_cooling_device_unregister(cdev);
freq_qos_remove_request(&cpufreq_cdev->qos_req);
ida_simple_remove(&cpufreq_ida, cpufreq_cdev->id);
- kfree(cpufreq_cdev->idle_time);
kfree(cpufreq_cdev);
}
EXPORT_SYMBOL_GPL(cpufreq_cooling_unregister);
--
2.25.0.rc1.19.g042ed3e048af
Powered by blists - more mailing lists