linux-kernel - RE: [EXT] [PATCH] tty: serial: fsl_lpuart: LS1021A has a FIFO size of 32 datawords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM8PR04MB731502EE715F1FDD70BDAD7BFF1A0@AM8PR04MB7315.eurprd04.prod.outlook.com>
Date:   Fri, 23 Oct 2020 01:44:45 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Walle <michael@...le.cc>
Subject: RE: [EXT] [PATCH] tty: serial: fsl_lpuart: LS1021A has a FIFO size of
 32 datawords

From: Vladimir Oltean <olteanv@...il.com> Sent: Thursday, October 22, 2020 11:13 PM
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Similar to the workaround applied by Michael Walle in commit c2f448cff22a
> ("tty: serial: fsl_lpuart: add LS1028A support"), it turns out that the
> LPUARTx_FIFO encoding for fields TXFIFOSIZE and RXFIFOSIZE is the same for
> LS1028A as for LS1021A.
> 
> The RXFIFOSIZE in the Layerscape SoCs is fixed at this value:
> 101 Receive FIFO/Buffer depth = 32 datawords.
> 
> When Andy Duan wrote the commit in Fixes: below, he assumed that the 101
> encoding means 64 datawords. But this is not true for Layerscape. So that
> commit broke LS1021A, and this patch is extending the workaround for LS1028A
> which appeared in the meantime, to fix that breakage.
> 
> When the driver thinks that it has a deeper FIFO than it really has, getty (user
> space) output gets truncated.
> 
> Many thanks to Michael for suggesting this!
> 
> Fixes: f77ebb241ce0 ("tty: serial: fsl_lpuart: correct the FIFO depth size")
> Suggested-by: Michael Walle <michael@...le.cc>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
Layerscape has different define for the FIFO size.

Reviewed-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> ff4b88c637d0..bd047e1f9bea 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -314,9 +314,10 @@ MODULE_DEVICE_TABLE(of, lpuart_dt_ids);
>  /* Forward declare this for the dma callbacks*/  static void
> lpuart_dma_tx_complete(void *arg);
> 
> -static inline bool is_ls1028a_lpuart(struct lpuart_port *sport)
> +static inline bool is_layerscape_lpuart(struct lpuart_port *sport)
>  {
> -       return sport->devtype == LS1028A_LPUART;
> +       return (sport->devtype == LS1021A_LPUART ||
> +               sport->devtype == LS1028A_LPUART);
>  }
> 
>  static inline bool is_imx8qxp_lpuart(struct lpuart_port *sport) @@ -1701,11
> +1702,11 @@ static int lpuart32_startup(struct uart_port *port)
> 
> UARTFIFO_FIFOSIZE_MASK);
> 
>         /*
> -        * The LS1028A has a fixed length of 16 words. Although it supports
> the
> -        * RX/TXSIZE fields their encoding is different. Eg the reference
> manual
> -        * states 0b101 is 16 words.
> +        * The LS1021A and LS1028A have a fixed FIFO depth of 16 words.
> +        * Although they support the RX/TXSIZE fields, their encoding is
> +        * different. Eg the reference manual states 0b101 is 16 words.
>          */
> -       if (is_ls1028a_lpuart(sport)) {
> +       if (is_layerscape_lpuart(sport)) {
>                 sport->rxfifo_size = 16;
>                 sport->txfifo_size = 16;
>                 sport->port.fifosize = sport->txfifo_size;
> --
> 2.25.1