linux-kernel - Re: [PATCH] arm64: dts: imx: Add Beacon i.MX8M Nano development kit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201023111632.GB48162@kozik-lap>
Date:   Fri, 23 Oct 2020 13:16:32 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Adam Ford <aford173@...il.com>
Cc:     arm-soc <linux-arm-kernel@...ts.infradead.org>,
        Adam Ford-BE <aford@...conembedded.com>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx: Add Beacon i.MX8M Nano development kit

On Fri, Oct 23, 2020 at 05:51:56AM -0500, Adam Ford wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> > > new file mode 100644
> > > index 000000000000..faa55d888065
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> > > @@ -0,0 +1,19 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +/*
> > > + * Copyright 2020 Compass Electronics Group, LLC
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "imx8mn.dtsi"
> > > +#include "imx8mn-beacon-som.dtsi"
> > > +#include "imx8mn-beacon-baseboard.dtsi"
> >
> > Why do you need baseboard as DTSI? Is is separate than kit? Judging by
> > contents look like just empty/fake DTS and the baseboard should be the
> > DTS.
> >
> > Another hint: Baseboard also does not have its compatible, so it cannot
> > exist in real life separate from the development kit...
> 
> The baseboard can handle two separate, mutually exclusive video
> outputs. It has a LVDS bridge chip and an HDMI bridge chip, but
> without the DSI and LCDIF support, neither can function.
> Right now, that LVDS chip doesn't have an upstream driver, but I plan
> to introduce it once the LCDIF, and DSI interfaces are available and
> functional.
> 
> Once there is video support, the kit-level DTS file will get support
> for one of the video outputs, and a second DTS file will get created
> to support the other.  Both of these kit-level files would include the
> baseboard and SOM DTSI files since they would be common to both kits.

Sounds good.

> 
> > > +
> > > +/ {
> > > +     model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
> > > +     compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn";
> >
> > Undocumented compatible.
> 
> I am still trying to learn the YAML rules.  Do I just add it to the
> fsl.yaml?  'beacon' is in the vendor-prefixes, but I looked and the
> 'imx8mm-beacon-kit' which is already in the kernel doesn't have a
> compatible either and they are virtually identical.

Enough will be adding it to the fsl.yaml. There is no strict need for
separate compatible for baseboard, although that's quite common practice
since you want to reuse it.

The beacon,imx8mm-beacon-kit is in fsl.yaml, so you can just duplicate
for imx8mn.

Best regards,
Krzysztof