linux-kernel - RE: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 11:55:38 +0000
From:   Sagar Kadam <sagar.kadam@...nfive.com>
To:     Peter Korsgaard <peter@...sgaard.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "Paul Walmsley ( Sifive)" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>
Subject: RE: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on
 FU540-C000 SoC

Hello Peter,

> -----Original Message-----
> From: Peter Korsgaard <jacmet@...il.com> On Behalf Of Peter Korsgaard
> Sent: Wednesday, October 21, 2020 9:16 PM
> To: Sagar Kadam <sagar.kadam@...nfive.com>
> Cc: linux-kernel@...r.kernel.org; linux-riscv@...ts.infradead.org; linux-
> i2c@...r.kernel.org; andrew@...n.ch; Paul Walmsley ( Sifive)
> <paul.walmsley@...ive.com>; palmer@...belt.com;
> aou@...s.berkeley.edu
> Subject: Re: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on
> FU540-C000 SoC
> 
> [External Email] Do not click links or attachments unless you recognize the
> sender and know the content is safe
> 
> >>>>> "Sagar" == Sagar Shrikant Kadam <sagar.kadam@...ive.com> writes:
> 
>  > The FU540-C000 has a broken IRQ and support was added earlier
>  > so that it will operate in polling mode, but seems to work only
>  > in case interrupts property is missing from the i2c0 dt-node.
>  > This should not be the case and the driver should handle polling
>  > mode with the interrupt property present in i2c0 node of the
>  > device tree.
>  > So check if it's the FU540-C000 soc and enable polling mode master
>  > xfers, as the IRQ for this chip is broken.
> 
>  > Fixes commit c45d4ba86731 ("i2c: ocores: add polling mode workaround
>  > for Sifive FU540-C000 SoC")
> 
>  > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@...ive.com>
> 
> LGTM, thanks.
> 
> Acked-by: Peter Korsgaard <peter@...sgaard.com>
> 

Thank you for the review and "Acked-by"

BR,
Sagar
> --
> Bye, Peter Korsgaard