linux-kernel - Re: [PATCH] staging: fieldbus: anybuss: jump to correct label in an error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGngYiXY95R5=fUPQ2aBXOQsPXrkp8E4TTmU_75pQZN9OuiUUA@mail.gmail.com>
Date:   Fri, 23 Oct 2020 09:37:12 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: fieldbus: anybuss: jump to correct label in an
 error path

Hi Jing, thank you for your patch.

Reviewed-by: Sven Van Asbroeck <TheSven73@...il.com>

On Mon, Oct 12, 2020 at 9:17 AM Jing Xiangfeng <jingxiangfeng@...wei.com> wrote:
>
> In current code, controller_probe() misses to call ida_simple_remove()
> in an error path. Jump to correct label to fix it.
>
> Fixes: 17614978ed34 ("staging: fieldbus: anybus-s: support the Arcx anybus controller")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>  drivers/staging/fieldbus/anybuss/arcx-anybus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> index 5b8d0bae9ff3..b5fded15e8a6 100644
> --- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> +++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> @@ -293,7 +293,7 @@ static int controller_probe(struct platform_device *pdev)
>         regulator = devm_regulator_register(dev, &can_power_desc, &config);
>         if (IS_ERR(regulator)) {
>                 err = PTR_ERR(regulator);
> -               goto out_reset;
> +               goto out_ida;
>         }
>         /* make controller info visible to userspace */
>         cd->class_dev = kzalloc(sizeof(*cd->class_dev), GFP_KERNEL);
> --
> 2.17.1
>