linux-kernel - Re: [PATCH] selftests/ftrace: remove _do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201023115111.1c0e8768@gandalf.local.home>
Date:   Fri, 23 Oct 2020 11:51:11 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Alexander Gordeev <agordeev@...ux.ibm.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christian Brauner <christian.brauner@...ntu.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

On Fri, 23 Oct 2020 11:49:48 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 23 Oct 2020 17:12:44 +0200
> Alexander Gordeev <agordeev@...ux.ibm.com> wrote:
> 
> > > Perhaps we should have:
> > > 
> > > 	# older kernels have do_fork, but newer kernels have kernel_clone
> > > 	echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter    
> > 
> > Would you suggest to do the same with all occurences in
> > eea11285dab3 ("tracing: switch to kernel_clone()")?
> > Otherwise it does not really make sense to just fix couple
> > of tests out of dozens.  
> 
> Yes. I haven't pulled in the updated tests, so I haven't hit the errors yet
> (nor have I merged my work with the switch to the new name yet). So those
> will most definitely break my tests.
> 
> But because it's a more generic issue, we should have a way to find what to
> use. Perhaps add to the test.d/functions, something like:
> 
> FUNCTION_FORK=`(if grep '\bkernel_clone\b' /proc/kallsyms > /dev/null; then
>                 echo kernel_clone; else echo '_do_fork'; fi)`
> 
> and use $FUNCTION_FORK everywhere that references it.
> 
> 

Let me pull in the latest changes, and whip up a patch that works on both
the older kernels as well as the newer ones.

-- Steve