linux-kernel - Re: [Intel-gfx] drm_modes: signed integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X9esEo-xzBmrNZ9Y-H6RJrhH6Y8UNavk58gdBtmbHKmMLNnVIoCq3g-h8boShQUBWYta6AgzqEc6eNSyXjweZ3F4EVfCtLMa5ySdJmQ60C8=@emersion.fr>
Date:   Fri, 23 Oct 2020 16:02:03 +0000
From:   Simon Ser <contact@...rsion.fr>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Pekka Paalanen <ppaalanen@...il.com>
Subject: Re: [Intel-gfx] drm_modes: signed integer overflow

On Friday, October 23, 2020 5:27 PM, Ville Syrjälä <ville.syrjala@...ux.intel.com> wrote:

> These are two extreme cases:

Thanks!

> > I'm trying to get
> > a fix for my user-space 1, and I'm wondering if int32_t is enough
> > after dividing by mode->htotal.
> > CC Pekka, just FYI (I think Weston has similar code).
>
> What's with those 1000000LL constants? Are you storing
> clock in Hz units?

We're storing the vertical refresh rate in mHz (milli-Hertz).