linux-kernel - Re: [PATCH v3 03/56] amdgpu: fix a few kernel-doc markup issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecb99629-f593-b389-60b3-dc6f1b306c8b@amd.com>
Date:   Fri, 23 Oct 2020 18:38:40 +0200
From:   Christian König <christian.koenig@....com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>
Cc:     Jonathan Corbet <corbet@....net>,
        Alex Deucher <alexander.deucher@....com>,
        Andrey Grodzovsky <andrey.grodzovsky@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>, Dennis Li <Dennis.Li@....com>,
        Evan Quan <evan.quan@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/56] amdgpu: fix a few kernel-doc markup issues

Am 23.10.20 um 18:32 schrieb Mauro Carvalho Chehab:
> A kernel-doc markup can't be mixed with a random comment,
> as it causes parsing problems.
>
> While here, change an invalid kernel-doc markup into
> a common comment.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Acked-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f8785bdec79c..1d4b54950528 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -239,9 +239,11 @@ bool amdgpu_device_supports_baco(struct drm_device *dev)
>   	return amdgpu_asic_supports_baco(adev);
>   }
>   
> +/*
> + * VRAM access helper functions
> + */
> +
>   /**
> - * VRAM access helper functions.
> - *
>    * amdgpu_device_vram_access - read/write a buffer in vram
>    *
>    * @adev: amdgpu_device pointer
> @@ -4497,7 +4499,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>   	bool need_emergency_restart = false;
>   	bool audio_suspended = false;
>   
> -	/**
> +	/*
>   	 * Special case: RAS triggered and full reset isn't supported
>   	 */
>   	need_emergency_restart = amdgpu_ras_need_emergency_restart(adev);