linux-kernel - Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKOiAp96yu=7OVn72R8EMukErBSXeWURJp3qTqrurtt0Q@mail.gmail.com>
Date:   Fri, 23 Oct 2020 18:51:05 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Ricardo Dias <rdias@...sql.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

On Fri, Oct 23, 2020 at 6:48 PM Ricardo Dias <rdias@...sql.com> wrote:
>

> In that case, I can change the patch to only iterate the ehash bucket
> only when the listening socket is using the loopback interface, correct?

No, the fix should be generic.

We could still have bad NIC, or bad configuration, spreading packets
on random cpus ;)