linux-kernel - Re: [PATCH] kbuild: remove unused OBJSIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201023181805.GA3852821@ubuntu-m3-large-x86>
Date:   Fri, 23 Oct 2020 11:18:05 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Vasily Gorbik <gor@...ux.ibm.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jonathan Corbet <corbet@....net>, linux-kbuild@...r.kernel.org,
        clang-built-linux@...glegroups.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: remove unused OBJSIZE

On Fri, Oct 23, 2020 at 01:57:32PM +0200, Vasily Gorbik wrote:
> The "size" tool has been solely used by s390 to enforce .bss section usage
> restrictions in early startup code. Since commit 980d5f9ab36b ("s390/boot:
> enable .bss section for compressed kernel") and commit 2e83e0eb85ca
> ("s390: clean .bss before running uncompressed kernel") these restrictions
> have been lifted for the decompressor and uncompressed kernel and the
> size tool is now unused.
> 
> Signed-off-by: Vasily Gorbik <gor@...ux.ibm.com>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

Thanks for the patch!

> ---
>  Documentation/kbuild/llvm.rst | 5 ++---
>  Makefile                      | 4 +---
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index cf3ca236d2cc..21c847890d03 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -57,9 +57,8 @@ to enable them. ::
>  They can be enabled individually. The full list of the parameters: ::
>  
>  	make CC=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \
> -	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-size \
> -	  READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \
> -	  HOSTLD=ld.lld
> +	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump READELF=llvm-readelf \
> +	  HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar HOSTLD=ld.lld
>  
>  Currently, the integrated assembler is disabled by default. You can pass
>  ``LLVM_IAS=1`` to enable it.
> diff --git a/Makefile b/Makefile
> index d35a59f98e83..d2123c2c829a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -433,7 +433,6 @@ NM		= llvm-nm
>  OBJCOPY		= llvm-objcopy
>  OBJDUMP		= llvm-objdump
>  READELF		= llvm-readelf
> -OBJSIZE		= llvm-size
>  STRIP		= llvm-strip
>  else
>  CC		= $(CROSS_COMPILE)gcc
> @@ -443,7 +442,6 @@ NM		= $(CROSS_COMPILE)nm
>  OBJCOPY		= $(CROSS_COMPILE)objcopy
>  OBJDUMP		= $(CROSS_COMPILE)objdump
>  READELF		= $(CROSS_COMPILE)readelf
> -OBJSIZE		= $(CROSS_COMPILE)size
>  STRIP		= $(CROSS_COMPILE)strip
>  endif
>  PAHOLE		= pahole
> @@ -509,7 +507,7 @@ KBUILD_LDFLAGS :=
>  CLANG_FLAGS :=
>  
>  export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC
> -export CPP AR NM STRIP OBJCOPY OBJDUMP OBJSIZE READELF PAHOLE RESOLVE_BTFIDS LEX YACC AWK INSTALLKERNEL
> +export CPP AR NM STRIP OBJCOPY OBJDUMP READELF PAHOLE RESOLVE_BTFIDS LEX YACC AWK INSTALLKERNEL
>  export PERL PYTHON PYTHON3 CHECK CHECKFLAGS MAKE UTS_MACHINE HOSTCXX
>  export KGZIP KBZIP2 KLZOP LZMA LZ4 XZ ZSTD
>  export KBUILD_HOSTCXXFLAGS KBUILD_HOSTLDFLAGS KBUILD_HOSTLDLIBS LDFLAGS_MODULE
> -- 
> 2.25.4