linux-kernel - Re: [GIT PULL] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgxBeNJTac5PDkzbdtvO3bZn+f9DzSHk-A6gzUAxFHVQw@mail.gmail.com>
Date:   Fri, 23 Oct 2020 12:05:12 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Networking

On Thu, Oct 22, 2020 at 2:48 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Latest fixes from the networking tree. Experimenting with the format
> of the description further, I'll find out if you liked it based on how
> it ends up looking in the tree :)

Looks fine to me. Honestly, the format isn't a huge deal, as long as
it's understandable. But I do like the grouping, since that increases
legibility.

A lot of my editing of these things end up being about trying to make
the merge messages from different people look somewhat uniform (a
couple of common patterns, and generally a somewhat common indentation
policy etc). And yours have already been closer to the norm than
David's numbering is, for example.

But I don't get _too_ hung up about it, the most important thing by
far is that I get a feeling for the overview of the changes, and that
I feel the commit message is useful and sensible for others that are
interested in what's going on (ie I will generally try to edit out
things like "This pull request does XYZ", because that kind of
language makes no sense once it's a merge commit in the history).

             Linus