linux-kernel - Re: [mm/page_alloc] 7fef431be9: vm-scalability.throughput 87.8% improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9F5E9E0C-A367-49EE-8764-58555C742F1E@redhat.com>
Date:   Fri, 23 Oct 2020 21:46:18 +0200
From:   David Hildenbrand <david@...hat.com>
To:     David Rientjes <rientjes@...gle.com>
Cc:     kernel test robot <rong.a.chen@...el.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Kevin Ko <kevko@...gle.com>,
        David Hildenbrand <david@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Oscar Salvador <osalvador@...e.de>,
        Wei Yang <richard.weiyang@...ux.alibaba.com>,
        Pankaj Gupta <pankaj.gupta.linux@...il.com>,
        Michal Hocko <mhocko@...e.com>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Dave Hansen <dave.hansen@...el.com>,
        Mike Rapoport <rppt@...nel.org>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michal Hocko <mhocko@...nel.org>,
        Scott Cheloha <cheloha@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        lkp@...el.com, ying.huang@...el.com, feng.tang@...el.com,
        zhengjun.xing@...el.com
Subject: Re: [mm/page_alloc] 7fef431be9: vm-scalability.throughput 87.8% improvement


> Am 23.10.2020 um 21:29 schrieb David Rientjes <rientjes@...gle.com>:
> 
> On Wed, 21 Oct 2020, kernel test robot wrote:
> 
>> Greeting,
>> 
>> FYI, we noticed a 87.8% improvement of vm-scalability.throughput due to commit:
>> 
>> 
>> commit: 7fef431be9c9ac255838a9578331567b9dba4477 ("mm/page_alloc: place pages to tail in __free_pages_core()")
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>> 
>> 
>> in testcase: vm-scalability
>> on test machine: 192 threads Intel(R) Xeon(R) Platinum 9242 CPU @ 2.30GHz with 192G memory
>> with following parameters:
>> 
>>    runtime: 300s
>>    size: 512G
>>    test: anon-wx-rand-mt
>>    cpufreq_governor: performance
>>    ucode: 0x5002f01
>> 
>> test-description: The motivation behind this suite is to exercise functions and regions of the mm/ of the Linux kernel which are of interest to us.
>> test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability.git/
>> 
> 
> I'm curious why we are not able to reproduce this improvement on Skylake 
> and actually see a slight performance degradation, at least for 
> 300s_128G_truncate_throughput.
> 
> Axel Rasmussen <axelrasmussen@...gle.com> can provide more details on our 
> results.
> 

As this patch only affects how we first place pages into the freelists when booting up, I‘d be surprised if there would be observable change in actual numbers. Run your system for long enough and it‘s all going to be random in the freelists anyway.

Looks more like random measurement anomalies to me. But maybe there are corner cases where the initial state of the freelists affects a benchmark when run immediately after boot?