linux-kernel - Re: [PATCH v2 09/15] perf record: introduce thread specific objects for trace streaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201024154431.GH2589351@krava>
Date:   Sat, 24 Oct 2020 17:44:31 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Alexey Budankov <alexey.budankov@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 09/15] perf record: introduce thread specific objects
 for trace streaming

On Wed, Oct 21, 2020 at 07:03:48PM +0300, Alexey Budankov wrote:
> 
> Introduce thread local data object and its array to be used for
> threaded trace streaming.
> 
> Signed-off-by: Alexey Budankov <alexey.budankov@...ux.intel.com>
> ---
>  tools/perf/builtin-record.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index ba26d75c51d6..8e512096a060 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -85,11 +85,29 @@ struct switch_output {
>  	int		 cur_file;
>  };
>  
> +struct thread_data {
> +	pid_t		   tid;
> +	struct {
> +		int	   msg[2];
> +		int	   ack[2];
> +	} comm;
> +	struct fdarray	   pollfd;
> +	int		   ctlfd_pos;
> +	struct mmap	   *maps;
> +	int		   nr_mmaps;
> +	struct record	   *rec;
> +	unsigned long long samples;
> +	unsigned long	   waking;
> +	u64		   bytes_written;
> +};

please merge the struct with the code that's using it

jirka

> +
>  struct record {
>  	struct perf_tool	tool;
>  	struct record_opts	opts;
>  	u64			bytes_written;
>  	struct perf_data	data;
> +	struct thread_data	*thread_data;
> +	int			nr_thread_data;
>  	struct auxtrace_record	*itr;
>  	struct evlist	*evlist;
>  	struct perf_session	*session;
> -- 
> 2.24.1
>