linux-kernel - Re: [linux-sunxi] [PATCH 03/10] ARM: dts: sun7i: cubietruck: Enable RGMII RX/TX delay on Ethernet PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47f00919-39fe-bbf3-32c7-e1375f34a7be@elopez.com.ar>
Date:   Sat, 24 Oct 2020 14:04:46 -0300
From:   Emilio López <emilio@...pez.com.ar>
To:     wens@...nel.org, Maxime Ripard <mripard@...nel.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>
Cc:     linux-sunxi@...glegroups.com, Chen-Yu Tsai <wens@...e.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [linux-sunxi] [PATCH 03/10] ARM: dts: sun7i: cubietruck: Enable
 RGMII RX/TX delay on Ethernet PHY

El 24/10/20 a las 13:25, Chen-Yu Tsai escribió:
> From: Chen-Yu Tsai <wens@...e.org>
> 
> The Ethernet PHY on the Cubietruck has the RX and TX delays
> enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
> 
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
> 
> Fixes: 67073d97672d ("ARM: dts: sun7i: cubietruck: Enable the GMAC")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
> ---
>   arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 8c8dee6ea461..9109ca0919ad 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -151,7 +151,7 @@ &gmac {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&gmac_rgmii_pins>;
>   	phy-handle = <&phy1>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>   	status = "okay";
>   };
>   
> 

I upgraded kernels yesterday and saw that networking had stopped 
working. I can confirm that this patch fixes the problem and restores 
connectivity on my Cubietruck. I also verified the information with the 
schematics, and it looks alright to me :)

Reviewed-by: Emilio López <emilio@...pez.com.ar>
Tested-by: Emilio López <emilio@...pez.com.ar>

Thanks!
Emilio