linux-kernel - Re: [PATCH v5] checkpatch: extend attributes check to handle more patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABJPP5Cc9H5w57qko372iU4t+_if2cp1TbOfTNRd9zt7bGDW5w@mail.gmail.com>
Date:   Sun, 25 Oct 2020 23:56:00 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v5] checkpatch: extend attributes check to handle more patterns

On Sun, Oct 25, 2020 at 11:49 PM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote:
> > On Sun, Oct 25, 2020 at 11:29 PM Joe Perches <joe@...ches.com> wrote:
> []
> > > Using $rawline would also change comments and that seems wrong.
> > > Any reason to use $rawline instead of $line?
> > Yes I used $line initially but changed it because quoted
> > strings were being replaced.
> >
> > Like:
> > __attribute__((__section__("_ftrace_events")))
>
> Right thanks, that's a very sensible tradeoff to reduce code complexity.
>

Okay. Do you see anything else that I should cover in the next
iteration?

If there is no other problem, I will do the space addition one and
resend it to you.

Thanks,
Dwaipayan.