linux-kernel - Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABJPP5AY7Vm4CBhhnqYo_LWFYY6PB2fgtk6CLR3tUEV1ZJNQpg@mail.gmail.com>
Date:   Sun, 25 Oct 2020 14:12:38 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns

On Sun, Oct 25, 2020 at 2:08 PM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2020-10-25 at 14:02 +0530, Dwaipayan Ray wrote:
> > And also do you think there should be a separate check
> > for __alias__(#symbol)? I think it expects a string and that should
> > be trimmed in the fix.
>
> For now, I think you should avoid both alias and section.
>
> There are patches to convert both of these macros to remove
> the stringify.
>
>
Okay I will do that.

And another quick question please.
Suppose we have non handled attributes in one such
multi attribute macro. (not present in our hash)

Like __attribute__((__packed, __something_not_handled))

For this case, do I skip the warning totally? Or something else?

Thanks,
Dwaipayan.