linux-kernel - Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v9eyo75s.wl-maz@kernel.org>
Date:   Sun, 25 Oct 2020 11:51:27 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     jbrunet@...libre.com, linux-amlogic@...ts.infradead.org,
        khilman@...libre.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

On Tue, 20 Oct 2020 08:25:30 +0100,
Neil Armstrong <narmstrong@...libre.com> wrote:
> 
> In order to reduce the kernel Image size on multi-platform distributions,
> make it possible to build the Amlogic GPIO IRQ controller as a module
> by switching it to a platform driver.
> 
> The second patch removes MESON_IRQ_GPIO selection from ARCH_MESON to allow
> building the driver as module.
> 
> Neil Armstrong (2):
>   irqchip: irq-meson-gpio: make it possible to build as a module
>   arm64: meson: remove MESON_IRQ_GPIO selection
> 
>  arch/arm64/Kconfig.platforms     |  1 -
>  drivers/irqchip/Kconfig          |  5 +-
>  drivers/irqchip/irq-meson-gpio.c | 89 ++++++++++++++++++++------------
>  3 files changed, 59 insertions(+), 36 deletions(-)

I've tried this series on my vim3l with the this driver compiled as a
module, and lost the Ethernet interface in the process, as the phy
wasn't able to resolve its interrupt and things fail later on:

[   72.238291] meson8b-dwmac ff3f0000.ethernet eth1: no phy at addr -1
[   72.238917] meson8b-dwmac ff3f0000.ethernet eth1: stmmac_open: Cannot attach to PHY (error: -19)

This is a generic problem with making DT-based interrupt controllers
modular when not *all* the drivers can deal with probing deferral.

	M.

-- 
Without deviation from the norm, progress is not possible.