linux-kernel - Re: [PATCH] mdio: use inline functions for to_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201026192058.GP752111@lunn.ch>
Date:   Mon, 26 Oct 2020 20:20:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mdio: use inline functions for to_mdio_device() etc

On Mon, Oct 26, 2020 at 05:51:09PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>

..

> Redefine the macros in linux/mdio.h as inline functions to avoid this
> problem.
> 
> Fixes: a9049e0c513c ("mdio: Add support for mdio drivers.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hi Arnd

It is nice to have the additional type checking.

Since you added a Fixes: tag, do you want this in stable?
netdev puts into the Subject line the tree it is intended for:

[PATCH net v1]

or

[PATCH net-next v1]

Anyway:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew