linux-kernel - Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

Open Source and information security mailing list archives

Message-ID: <22ab9117-0281-2ff3-8328-d7780e353643@amd.com>
Date:   Mon, 26 Oct 2020 16:22:19 -0400
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>
To:     Alex Deucher <alexdeucher@...il.com>,
        Luben Tuikov <luben.tuikov@....com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@....com>

Looks fine to me. Feel free to apply.

Regards,
Nicholas Kazlauskas

On 2020-10-26 3:34 p.m., Alex Deucher wrote:
> Yes, looks good to me as well.  Series is:
> Acked-by: Alex Deucher <alexander.deucher@....com>
> I'll give the display guys a few more days to look this over, but if
> there are no objections, I'll apply them.
> 
> Thanks!
> 
> Alex
> 
> On Fri, Oct 23, 2020 at 7:16 PM Luben Tuikov <luben.tuikov@....com> wrote:
>>
>> On 2020-10-23 03:46, Takashi Iwai wrote:
>>> Hi,
>>>
>>> the amdgpu driver's ASSERT_CRITICAL() macro calls the
>>> kgdb_breakpoing() even if no debug option is set, and this leads to a
>>> kernel panic on distro kernels.  The first two patches are the
>>> oneliner fixes for those, while the last one is the cleanup of those
>>> debug macros.
>>
>> This looks like good work and solid. Hopefully it gets picked up.
>>
>> Regards,
>> Luben
>>
>>>
>>>
>>> Takashi
>>>
>>> ===
>>>
>>> Takashi Iwai (3):
>>>    drm/amd/display: Fix kernel panic by dal_gpio_open() error
>>>    drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
>>>    drm/amd/display: Clean up debug macros
>>>
>>>   drivers/gpu/drm/amd/display/Kconfig             |  1 +
>>>   drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c |  4 +--
>>>   drivers/gpu/drm/amd/display/dc/os_types.h       | 33 +++++++++----------------
>>>   3 files changed, 15 insertions(+), 23 deletions(-)
>>>
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives