[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201026203608.GJ7402@sirena.org.uk>
Date: Mon, 26 Oct 2020 20:36:08 +0000
From: Mark Brown <broonie@...nel.org>
To: Fabien Parent <fparent@...libre.com>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
DTML <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Rob Herring <robh+dt@...nel.org>, lgirdwood@...il.com,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392
On Mon, Oct 26, 2020 at 07:38:14PM +0100, Fabien Parent wrote:
> On Mon, Oct 26, 2020 at 6:24 PM Mark Brown <broonie@...nel.org> wrote:
> > > .name = "mt6392-regulator",
> > > .of_compatible = "mediatek,mt6392-regulator"
> > This is still unneeded, it's just a reflection of Linux implementation
> > details and should be removed. The MFD can just register the child
> > without supplying a compatible and things will continue to work just as
> > well.
> I'm not exactly sure how it is supposed to work. mfd_add_devices seems
> to register devices based on of_compatible or acpi_match from the
> mfd_cell. This platform does not have ACPI so I don't understand how
It should also support unconditionally registering devices, if it no
longer does so that's a regression in the framework which should be
fixed. Looking at mfd_add_devices() I can't see an issue though, both
ACPI and DT information is optional - the entire DT section in
mfd_add_device() will be skipped if no of_compatible is specified in the
cell. Are you *sure* that the regulator driver isn't running?
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists