linux-kernel - Re: [PATCH v3] ASoC: Intel: boards: Add CML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ade3e3c-c55d-d137-0af2-b2b32c16cfd7@linux.intel.com>
Date:   Mon, 26 Oct 2020 14:22:13 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Keith Tzneg <matsufan@...il.com>, alsa-devel@...a-project.org
Cc:     Cezary Rojewski <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Naveen Manohar <naveen.m@...el.com>,
        Yong Zhi <yong.zhi@...el.com>,
        Libin Yang <libin.yang@...ux.intel.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Sathyanarayana Nujella <sathyanarayana.nujella@...el.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Fred Oh <fred.oh@...ux.intel.com>,
        Mac Chiang <mac.chiang@...el.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Keith Tzeng <keith.tzeng@...nta.corp-partner.google.com>,
        Brent Lu <brent.lu@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ASoC: Intel: boards: Add CML_RT1015 m/c driver



On 10/23/20 11:51 PM, Keith Tzneg wrote:
> From: Keith Tzeng <keith.tzeng@...nta.corp-partner.google.com>
> 
> Machine driver to enable RT5682 on SSP0, DMIC, HDMI and RT1015 AMP on
> SSP1: Enabled 4 CH TDM playback with 24 bit data.

Same comment for the third time: there is no reason to add an entire 
machine driver just to replace one amplifier by another.

let's use an existing machine driver and use a quirk (DMI or table_id) 
to select the relevant amp for that device.