linux-kernel - Re: [PATCH 2/2] mailbox: stm32-ipcc: remove duplicate error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc47f0cd-ebbf-8093-6197-43e98e7ffc73@st.com>
Date:   Mon, 26 Oct 2020 08:12:26 +0000
From:   Fabien DESSENNE <fabien.dessenne@...com>
To:     Martin Kaiser <martin@...ser.cx>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>
CC:     "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mailbox: stm32-ipcc: remove duplicate error message

Hi Martin


Thank you for the patch

On 24/10/2020 3:31 pm, Martin Kaiser wrote:
> platform_get_irq_byname already prints an error message if the requested irq
> was not found. Don't print another message in the driver.
>
> Signed-off-by: Martin Kaiser <martin@...ser.cx>


Reviewed-by: Fabien Dessenne <fabien.dessenne@...com>


> ---
>   drivers/mailbox/stm32-ipcc.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
> index ef966887aa15..ab8fe56af948 100644
> --- a/drivers/mailbox/stm32-ipcc.c
> +++ b/drivers/mailbox/stm32-ipcc.c
> @@ -257,9 +257,6 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
>   	for (i = 0; i < IPCC_IRQ_NUM; i++) {
>   		ipcc->irqs[i] = platform_get_irq_byname(pdev, irq_name[i]);
>   		if (ipcc->irqs[i] < 0) {
> -			if (ipcc->irqs[i] != -EPROBE_DEFER)
> -				dev_err(dev, "no IRQ specified %s\n",
> -					irq_name[i]);
>   			ret = ipcc->irqs[i];
>   			goto err_clk;
>   		}