linux-kernel - Re: [PATCH] usb: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <845e43b3-1c53-3eed-b540-4efa109f33a9@linux.intel.com>
Date:   Mon, 26 Oct 2020 16:23:47 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     trix@...hat.com, balbi@...nel.org, gregkh@...uxfoundation.org,
        mathias.nyman@...el.com, johan@...nel.org,
        stern@...land.harvard.edu, gustavoars@...nel.org,
        viro@...iv.linux.org.uk, lee.jones@...aro.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        usb-storage@...ts.one-eyed-alien.net
Subject: Re: [PATCH] usb: remove unneeded break

On 19.10.2020 18.02, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A break is not needed if it is preceded by a return or goto
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/usb/gadget/function/f_hid.c | 9 ---------
>  drivers/usb/host/xhci-mem.c         | 1 -
>  drivers/usb/misc/iowarrior.c        | 3 ---
>  drivers/usb/serial/iuu_phoenix.c    | 2 --
>  drivers/usb/storage/freecom.c       | 1 -
>  5 files changed, 16 deletions(-)

Would probably be better to split this into several patches.
The xhci change looks good (as a separate patch)

-Mathias