linux-kernel - RE: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB66876F05E9988139C03294498F190@VE1PR04MB6687.eurprd04.prod.outlook.com>
Date:   Mon, 26 Oct 2020 14:35:47 +0000
From:   Leo Li <leoyang.li@....com>
To:     Shawn Guo <shawnguo@...nel.org>,
        Meenakshi Aggarwal <meenakshi.aggarwal@....com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Varun Sethi <V.Sethi@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Kuldeep Singh <kuldeep.singh@....com>
Subject: RE: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for
 lx2162aqds board



> -----Original Message-----
> From: Shawn Guo <shawnguo@...nel.org>
> Sent: Monday, October 26, 2020 2:19 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
> Cc: robh+dt@...nel.org; Varun Sethi <V.Sethi@....com>; Leo Li
> <leoyang.li@....com>; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Ioana Ciornei
> <ioana.ciornei@....com>; Kuldeep Singh <kuldeep.singh@....com>
> Subject: Re: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for
> lx2162aqds board
> 
> On Mon, Oct 19, 2020 at 09:00:33AM +0000, Meenakshi Aggarwal wrote:
> > Hi,
> >
> > Any further comments?
> 
> Please address the following checkpatch warnings.
> 
> WARNING: DT compatible string "nxp,lx2162a-qds" appears un-documented
> -- check ./Documentation/devicetree/bindings/
> #49: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:13:
> +	compatible = "nxp,lx2162a-qds", "fsl,lx2160a";
> 
> WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un-
> documented -- check ./Documentation/devicetree/bindings/
> #80: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:44:
> +				compatible = "ethernet-phy-id001c.c916";

Interesting that it doesn't match the following in Documentation/devicetree/bindings/net/ethernet-phy.yaml

      - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
        description:
          If the PHY reports an incorrect ID (or none at all) then the
          compatible list may contain an entry with the correct PHY ID
          in the above form.
          The first group of digits is the 16 bit Phy Identifier 1
          register, this is the chip vendor OUI bits 3:18. The
          second group of digits is the Phy Identifier 2 register,
          this is the chip vendor OUI bits 19:24, followed by 10
          bits of a vendor specific ID.

> 
> WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un-
> documented -- check ./Documentation/devicetree/bindings/
> #92: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:56:
> +				compatible = "ethernet-phy-id001c.c916";
> 
> 
> Shawn