[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201026144943.30821-1-grzegorz.jaszczyk@linaro.org>
Date: Mon, 26 Oct 2020 15:49:43 +0100
From: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
To: ssantosh@...nel.org, s-anna@...com
Cc: grzegorz.jaszczyk@...aro.org, santosh.shilimkar@...cle.com,
lee.jones@...aro.org, linux-kernel@...r.kernel.org,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
praneeth@...com, tony@...mide.com,
Wei Yongjun <weiyongjun1@...wei.com>
Subject: [PATCH] soc: ti: pruss: Remove wrong check against *get_match_data return value
Since the of_device_get_match_data() doesn't return error code, remove
wrong IS_ERR test. Proper check against NULL pointer is already done
later before usage: if (data && data->...).
Additionally, proceeding with empty device data is valid (e.g. in case
of "ti,am3356-pruss").
Reported-by: Wei Yongjun <weiyongjun1@...wei.com>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
---
drivers/soc/ti/pruss.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
index cc0b4ad7a3d3..5d6e7132a5c4 100644
--- a/drivers/soc/ti/pruss.c
+++ b/drivers/soc/ti/pruss.c
@@ -126,8 +126,6 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
int ret = 0;
data = of_device_get_match_data(dev);
- if (IS_ERR(data))
- return -ENODEV;
clks_np = of_get_child_by_name(cfg_node, "clocks");
if (!clks_np) {
@@ -175,10 +173,6 @@ static int pruss_probe(struct platform_device *pdev)
const char *mem_names[PRUSS_MEM_MAX] = { "dram0", "dram1", "shrdram2" };
data = of_device_get_match_data(&pdev->dev);
- if (IS_ERR(data)) {
- dev_err(dev, "missing private data\n");
- return -ENODEV;
- }
ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
if (ret) {
--
2.29.0
Powered by blists - more mailing lists