[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201026160142.GT20115@casper.infradead.org>
Date: Mon, 26 Oct 2020 16:01:42 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Muchun Song <songmuchun@...edance.com>
Cc: corbet@....net, mike.kravetz@...cle.com, tglx@...utronix.de,
mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com,
dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
viro@...iv.linux.org.uk, akpm@...ux-foundation.org,
paulmck@...nel.org, mchehab+huawei@...nel.org,
pawan.kumar.gupta@...ux.intel.com, rdunlap@...radead.org,
oneukum@...e.com, anshuman.khandual@....com, jroedel@...e.de,
almasrymina@...gle.com, rientjes@...gle.com,
duanxiongchun@...edance.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 07/19] mm/hugetlb: Free the vmemmap pages associated
with each hugetlb page
On Mon, Oct 26, 2020 at 10:51:02PM +0800, Muchun Song wrote:
> +static void split_vmemmap_pmd(pmd_t *pmd, pte_t *pte_p, unsigned long addr)
> +{
> + struct mm_struct *mm = &init_mm;
> + struct page *page;
> + pmd_t old_pmd, _pmd;
> + int i;
> +
> + old_pmd = READ_ONCE(*pmd);
> + page = pmd_page(old_pmd);
> + pmd_populate_kernel(mm, &_pmd, pte_p);
> +
> + for (i = 0; i < VMEMMAP_HPAGE_NR; i++, addr += PAGE_SIZE) {
> + pte_t entry, *pte;
> +
> + entry = mk_pte(page + i, PAGE_KERNEL);
I'd be happier if that were:
pgprot_t pgprot = PAGE_KERNEL;
...
for (i = 0; i < VMEMMAP_HPAGE_NR; i++, addr += PAGE_SIZE) {
pte_t entry, *pte;
entry = mk_pte(page + i, pgprot);
pgprot = PAGE_KERNEL_RO;
so that all subsequent tail pages are mapped read-only.
Powered by blists - more mailing lists