linux-kernel - Re: [PATCH] seqlock: avoid -Wshadow warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201026165805.GS2594@hirez.programming.kicks-ass.net>
Date:   Mon, 26 Oct 2020 17:58:05 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Marco Elver <elver@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seqlock: avoid -Wshadow warnings

On Mon, Oct 26, 2020 at 05:50:38PM +0100, Arnd Bergmann wrote:

> -	unsigned seq;							\
> +	unsigned __seq;							\

> -	unsigned seq = __read_seqcount_begin(s);			\
> +	unsigned _seq = __read_seqcount_begin(s);			\

> -	unsigned seq = __seqcount_sequence(s);				\
> +	unsigned __seq = __seqcount_sequence(s);			\

Can we have a consistent number of leading '_' ?

Also, I suppose you're going to find the explicit shadow in
___wait_event(), that one's not going to be trivial to fix.