linux-kernel - Re: [PATCH] crypto: caam - enable crypto-engine retry mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebdad102-fe91-7324-8096-dc1dc2313786@nxp.com>
Date:   Mon, 26 Oct 2020 19:11:26 +0200
From:   Iuliana Prodan <iuliana.prodan@....com>
To:     Horia Geantă <horia.geanta@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Silvano Di Ninno <silvano.dininno@....com>,
        Franck Lenormand <franck.lenormand@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Andrei Botila <andrei.botila@....com>,
        Dragos Rosioru <dragos.rosioru@....com>
Subject: Re: [PATCH] crypto: caam - enable crypto-engine retry mechanism

On 10/26/2020 5:36 PM, Horia Geantă wrote:
> On 10/21/2020 11:07 PM, Iuliana Prodan wrote:
>> Use the new crypto_engine_alloc_init_and_set() function to
>> initialize crypto-engine and enable retry mechanism.
>>
>> Set the maximum size for crypto-engine software queue based on
>> Job Ring size (JOBR_DEPTH) and a threshold (reserved for the
>> non-crypto-API requests that are not pass through crypto-engine).
> 				       ^ passed
> 
>>
>> The callback for do_batch_requests is NULL, since CAAM
>> doesn't support linked requests.
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
>> ---
>>   drivers/crypto/caam/intern.h | 3 +++
>>   drivers/crypto/caam/jr.c     | 6 +++++-
>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/caam/intern.h b/drivers/crypto/caam/intern.h
>> index 9112279..44fe6ee 100644
>> --- a/drivers/crypto/caam/intern.h
>> +++ b/drivers/crypto/caam/intern.h
>> @@ -16,6 +16,9 @@
>>   /* Currently comes from Kconfig param as a ^2 (driver-required) */
>>   #define JOBR_DEPTH (1 << CONFIG_CRYPTO_DEV_FSL_CAAM_RINGSIZE)
>>   
>> +#define THRESHOLD 15
> Unless there's a comment added for THRESHOLD (e.g. what's in the
> commit message), I don't think the define is helpful.
> 
>> +#define CRYPTO_ENGINE_MAX_QLEN (2 * (JOBR_DEPTH - THRESHOLD))
>> +
> What's the logic behind multiplying by 2?

I added the 2 as the number of Job Rings.
My logic was that crypto-engine is one per CAAM (x no of JRs), while 
JOB_DEPTH is per JR.
I know there are targets with other than 2 JRs. Therefore, is there a 
way to get this number automatically?


Thanks,
Iulia

>>   /* Kconfig params for interrupt coalescing if selected (else zero) */
>>   #ifdef CONFIG_CRYPTO_DEV_FSL_CAAM_INTC
>>   #define JOBR_INTC JRCFG_ICEN
>> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
>> index 6f66996..88540c9 100644
>> --- a/drivers/crypto/caam/jr.c
>> +++ b/drivers/crypto/caam/jr.c
>> @@ -550,7 +550,11 @@ static int caam_jr_probe(struct platform_device *pdev)
>>   	}
>>   
>>   	/* Initialize crypto engine */
>> -	jrpriv->engine = crypto_engine_alloc_init(jrdev, false);
>> +	jrpriv->engine = crypto_engine_alloc_init_and_set(jrdev,
>> +							  true,
>> +							  NULL,
>> +							  false,
>> +							  CRYPTO_ENGINE_MAX_QLEN);
> Let's make the argument list more compact.
> 
> Horia
>