linux-kernel - Re: [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in Exynos4412 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201027103827.GB20429@kozik-lap>
Date:   Tue, 27 Oct 2020 11:38:27 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Kukjin Kim <kgene@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in
 Exynos4412 boards

On Mon, Oct 26, 2020 at 10:02:10PM +0100, Marek Szyprowski wrote:
> 
> On 26.10.2020 19:15, Krzysztof Kozlowski wrote:
> > The Devicetree specification expects device node names to have a generic
> > name, representing the class of a device.  Also the convention for node
> > names is to use hyphens, not underscores.
> >
> > No functional changes.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >   arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi   |  8 ++++----
> >   arch/arm/boot/dts/exynos4412-itop-elite.dts   |  2 +-
> >   .../boot/dts/exynos4412-itop-scp-core.dtsi    |  2 +-
> >   arch/arm/boot/dts/exynos4412-midas.dtsi       | 12 +++++------
> >   arch/arm/boot/dts/exynos4412-n710x.dts        |  2 +-
> >   .../boot/dts/exynos4412-odroid-common.dtsi    |  8 ++++----
> >   arch/arm/boot/dts/exynos4412-odroidx.dts      |  4 ++--
> >   arch/arm/boot/dts/exynos4412-origen.dts       | 14 ++++++-------
> >   arch/arm/boot/dts/exynos4412-smdk4412.dts     | 20 +++++++++----------
> >   9 files changed, 36 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > index 89ed81fb348d..db91678f5648 100644
> > --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > @@ -15,7 +15,7 @@ aliases {
> >   		i2c10 = &i2c_cm36651;
> >   	};
> >   
> > -	aat1290 {
> > +	led-controller {
> >   		compatible = "skyworks,aat1290";
> >   		flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> >   		enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> > @@ -60,7 +60,7 @@ i2c_ak8975: i2c-gpio-0 {
> >   		#size-cells = <0>;
> >   		status = "okay";
> >   
> > -		ak8975@c {
> > +		magnetometer@c {
> >   			compatible = "asahi-kasei,ak8975";
> >   			reg = <0x0c>;
> >   			gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
> > @@ -75,7 +75,7 @@ i2c_cm36651: i2c-gpio-2 {
> >   		#address-cells = <1>;
> >   		#size-cells = <0>;
> >   
> > -		cm36651@18 {
> > +		sensor@18 {
> light-sensor?

Ack, to this and all following. Thanks.

Best regards,
Krzysztof